Who wins the battle investor or trader?

Putting market participants into categories makes as much sense as stating that proper asset allocation accounts for the bulk of your return. You have to be good at whatever you are doing. Professionals win, suckers lose. Or, if you prefer: bulls make money, bears make money, pigs get slaughtered.

longterm = investor

shortterm = savvy trader

investor that hold their investment term will win!
Trader can loss & make money in short term but they stand to lose over the long term cause they will always speculate...!
hope that answer your question1

If you can believe Warren Buffet, than the trader has the definite advantage.

It is quite common for traders to earn a 100% annual return, or more, I'd like to see an investor who can come close to that.

The problem is that there is a limited amount of money that one can efficiently move in and out of a trade. And poor old Warren has just got too much. Try trading a billion dollars worth of stock a few times and you'll see what I mean. For those of us who don't have Warren's money "problem", trading is far more lucrative than investing.

That's if you don't lose all your money before you figure out how.

At some point success will force the good trader to become an investor.